From 821832770c88929b87b3db7285dd51594415bbaf Mon Sep 17 00:00:00 2001 From: rubenwardy Date: Mon, 26 Mar 2018 12:55:41 +0100 Subject: [PATCH] Use .get() instead of filter_by() for primary key queries --- app/views/packages.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/views/packages.py b/app/views/packages.py index dfe7af0..d1bf20e 100644 --- a/app/views/packages.py +++ b/app/views/packages.py @@ -283,7 +283,7 @@ def create_editrequest_page(ptype, author, name): def view_editrequest_page(ptype, author, name, id): package = getPageByInfo(ptype, author, name) - erequest = EditRequest.query.filter_by(id=id).first() + erequest = EditRequest.query.get(id) if erequest is None: abort(404) @@ -297,7 +297,7 @@ def approve_editrequest_page(ptype, author, name, id): flash("You don't have permission to do that.", "error") return redirect(package.getDetailsURL()) - erequest = EditRequest.query.filter_by(id=id).first() + erequest = EditRequest.query.get(id) if erequest is None: abort(404) @@ -318,7 +318,7 @@ def reject_editrequest_page(ptype, author, name, id): flash("You don't have permission to do that.", "error") return redirect(package.getDetailsURL()) - erequest = EditRequest.query.filter_by(id=id).first() + erequest = EditRequest.query.get(id) if erequest is None: abort(404) @@ -387,7 +387,7 @@ def edit_release_page(type, author, name, id): if user is None: abort(404) - release = PackageRelease.query.filter_by(id=id).first() + release = PackageRelease.query.get(id) if release is None: abort(404)