Rampoina
/
MegaGlest
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

- a little bit of code hardening (looking for invalid data conditions and NULL's)

This commit is contained in:
Mark Vejvoda 2011-01-10 21:23:52 +00:00
parent a9534e727e
commit 8bf83c03a8
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
source/shared_lib/sources/xml/xml_parser.cpp
View File

@ -187,28 +187,30 @@ XmlNode::XmlNode(DOMNode *node){
}
//get name
char str[strSize];
char str[strSize]="";
XMLString::transcode(node->getNodeName(), str, strSize-1);
name= str;
//check document
if(node->getNodeType()==DOMNode::DOCUMENT_NODE){
if(node->getNodeType() == DOMNode::DOCUMENT_NODE) {
name="document";
}
//check children
for(unsigned int i=0; i<node->getChildNodes()->getLength(); ++i){
DOMNode *currentNode= node->getChildNodes()->item(i);
if(currentNode->getNodeType()==DOMNode::ELEMENT_NODE){
XmlNode *xmlNode= new XmlNode(currentNode);
children.push_back(xmlNode);
}
if(node->getChildNodes() != NULL) {
for(unsigned int i = 0; i < node->getChildNodes()->getLength(); ++i) {
DOMNode *currentNode= node->getChildNodes()->item(i);
if(currentNode != NULL && currentNode->getNodeType()==DOMNode::ELEMENT_NODE){
XmlNode *xmlNode= new XmlNode(currentNode);
children.push_back(xmlNode);
}
}
}
//check attributes
DOMNamedNodeMap *domAttributes= node->getAttributes();
if(domAttributes!=NULL){
for(unsigned int i=0; i<domAttributes->getLength(); ++i){
if(domAttributes != NULL) {
for(unsigned int i = 0; i < domAttributes->getLength(); ++i) {
DOMNode *currentNode= domAttributes->item(i);
if(currentNode->getNodeType()==DOMNode::ATTRIBUTE_NODE){
XmlAttribute *xmlAttribute= new XmlAttribute(domAttributes->item(i));
@ -218,7 +220,7 @@ XmlNode::XmlNode(DOMNode *node){
}
//get value
if(node->getNodeType()==DOMNode::ELEMENT_NODE && children.size()==0){
if(node->getNodeType() == DOMNode::ELEMENT_NODE && children.size() == 0) {
char *textStr= XMLString::transcode(node->getTextContent());
text= textStr;
XMLString::release(&textStr);