LibreGaming/matchmaking-bot
LibreGaming
/
matchmaking-bot
16
0
Fork 1
Code Issues 6 Pull Requests Projects Releases Wiki Activity

WIP: fix to work with newer ircrobots and python versions #8

Closed
Skyflare wants to merge 2 commits from (deleted):master into master
pull from: (deleted):master
merge into: LibreGaming:master
Conversation 1 Commits 2 Files Changed 2 +4 -1
Skyflare commented 2023-08-25 10:37:20 +02:00
Owner
Copy Link

partially? fixes #6

function ConnectionParams parameters were changed but never documented properly, by removing the fourth parameter (True) it should now work and TLS will be enabled by default with python 3.11 and ircrobots 0.6.6

Note: due to many undocumented changes between 0.6.1 and the latest version I am not sure if TLS will work with older versions of ircrobots with this patch

Todo:

  • get the PR tested by other people
  • test if TLS is working in practice
partially? fixes #6 function ConnectionParams parameters were changed but never documented properly, by removing the fourth parameter (True) it should now work and TLS will be enabled by default with python 3.11 and ircrobots 0.6.6 Note: due to many undocumented changes between 0.6.1 and the latest version I am not sure if TLS will work with older versions of ircrobots with this patch Todo: - [x] get the PR tested by other people - [x] test if TLS is working in practice
Skyflare added 2 commits 2023-08-25 10:37:21 +02:00
Skyflare changed title from WIP: fix to work with newer ircrobots and python versions [Needs testing] to fix to work with newer ircrobots and python versions 2023-08-26 00:54:50 +02:00
Skyflare changed title from fix to work with newer ircrobots and python versions to WIP: fix to work with newer ircrobots and python versions 2023-08-26 00:57:37 +02:00
Skyflare closed this pull request 2023-08-26 21:45:48 +02:00
Skyflare commented 2023-08-26 21:46:24 +02:00
Author
Owner
Copy Link

Closed as I already commited the required changes to the repo

Closed as I already commited the required changes to the repo

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LibreGaming/matchmaking-bot#8
No description provided.
Delete Branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?